test_rclcpp :- Add local and async set_parameters_atomically tests#595
test_rclcpp :- Add local and async set_parameters_atomically tests#595Aaravanand00 wants to merge 1 commit into
Conversation
|
Tick the box to add this pull request to the merge queue (same as
|
e3e91bf to
1c21c36
Compare
fujitatomoya
left a comment
There was a problem hiding this comment.
the original issue is almost 8 years ago, but this test case is still missing. lgtm. thanks for the contribution.
fujitatomoya
left a comment
There was a problem hiding this comment.
sorry, can you target this against rolling branch? that is where we develop as mainline.
1c21c36 to
8bee3f0
Compare
8bee3f0 to
d8c68b4
Compare
…2#282) Signed-off-by: Aaravanand00 <aaravanand5749@gmail.com>
d8c68b4 to
fb3d20d
Compare
done ptal |
is there any other test that you should want me to resolve first then let me know |
|
Pulls: #595 |
|
@fujitatomoya Thank you for the review and approval I see the CI jobs returned unstable which seems to be due to existing flaky tests in the repository rather than these changes. Please let me know if there is anything else you need from my side before this can be merged...... |
Description
This PR adds the missing tests for
set_parameters_atomicallyto thetest_rclcppsuite. It includes both local parameter assignment and remote asynchronous parameter assignment tests.Changes included:
test_set_parameters_atomically_asynchelper function toparameter_fixtures.hpp.local_set_parameters_atomicallytest case intest_local_parameters.cppto verify atomic parameter assignment on a local node.set_parameters_atomicallytests totest_remote_parameters.cppto verify remote atomic assignment (both for regular parameters and strictparameters_must_declarenodes).Fixes #282
Is this user-facing behavior change?
Did you use Generative AI?
Yes, this pull request was generated with the assistance of Antigravity (a generative AI assistant ) to implement the test logic and boilerplate.
Additional Information
All newly added integration tests successfully pass locally against the Jazzy distribution in a WSL2 Ubuntu 24.04 environment.