Skip to content

Check socket is actually freed and reusable during shutdown daemon. (backport #1230)#1231

Merged
ahcorde merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-1230
May 15, 2026
Merged

Check socket is actually freed and reusable during shutdown daemon. (backport #1230)#1231
ahcorde merged 1 commit into
lyricalfrom
mergify/bp/lyrical/pr-1230

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify Bot commented May 14, 2026

Description

Closes #1229

Is this user-facing behavior change?

Not really, only when the daemon is shutdown, it guarantees that the socket is reusable on the address/port. (only for windows.)

Did you use Generative AI?

Yes, partially Claude Opus 4.7

Additional Information


This is an automatic backport of pull request #1230 done by [Mergify](https://mergify.com).

…1230)

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
(cherry picked from commit 9c05387)
@fujitatomoya
Copy link
Copy Markdown
Collaborator

Pulls: #1231
Gist: https://gist.githubusercontent.com/fujitatomoya/9312609441312a9c909c0a93c5b1ce73/raw/9793427c9fadfa6202a44008cd62634dbcb20552/ros2.repos
BUILD args: --packages-above-and-dependencies ros2cli
TEST args: --packages-above ros2cli
ROS Distro: lyrical
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19273

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit fb2d293 into lyrical May 15, 2026
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/lyrical/pr-1230 branch May 15, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants