Skip to content

Add unit tests for sub-command tab completers#1227

Merged
ahcorde merged 3 commits into
ros2:rollingfrom
MzKyle:rolling-dco
May 15, 2026
Merged

Add unit tests for sub-command tab completers#1227
ahcorde merged 3 commits into
ros2:rollingfrom
MzKyle:rolling-dco

Conversation

@MzKyle
Copy link
Copy Markdown
Contributor

@MzKyle MzKyle commented May 4, 2026 •
edited
Loading

Add unit tests for the existing completer helpers/classes in ros2component, ros2node, ros2run, ros2service, and ros2topic.
Fixes #1173
Validation:

  • get_errors reported no syntax or lint diagnostics in the new test files.
  • Local source inspection confirms the new ros2topic expectation matches the workspace implementation.

MzKyle added 2 commits May 3, 2026 23:37
@MzKyle
test: add action completer coverage
4f19cea 
Signed-off-by: MzKyle <19862681939@163.com>
@MzKyle
Add unit tests for tab completers
d60f05f 
Signed-off-by: MzKyle <19862681939@163.com>
@MzKyle MzKyle mentioned this pull request May 5, 2026
Closed
fujitatomoya
fujitatomoya reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests look good, just a minor nitpick we need to address.

thanks for the contribution though!

Comment thread ros2node/test/test_api.py Outdated
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented May 14, 2026

@MzKyle thanks for quick response!

fujitatomoya
fujitatomoya reviewed May 14, 2026
View reviewed changes
Comment thread .marscode/deviceInfo.json Outdated
@MzKyle
Update copyright year to 2026 in new test files
05fbe61 
Signed-off-by: MzKyle <19862681939@163.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented May 14, 2026

Pulls: #1227
Gist: https://gist.githubusercontent.com/fujitatomoya/cb569fdd0c0e00a3c75266b802636563/raw/474f8fafd0124891908624c69202451e4de47ad3/ros2.repos
BUILD args: --packages-above-and-dependencies ros2action ros2component ros2node ros2run ros2service ros2topic
TEST args: --packages-above ros2action ros2component ros2node ros2run ros2service ros2topic
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19272

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit fe5f814 into ros2:rolling May 15, 2026
3 checks passed
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented May 15, 2026

@fujitatomoya should we backport this to older distros?

@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented May 15, 2026

@Mergifyio backport lyrical

@mergify
Copy link
Copy Markdown

mergify Bot commented May 15, 2026 •
edited
Loading

backport lyrical

✅ Backports have been created

Details

@mergify mergify Bot mentioned this pull request May 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add unit tests for sub-command tab completer

3 participants

@MzKyle @fujitatomoya @ahcorde