Make ros2 action info --verbose consistent with topic/service info#1220
Open
catplotlib wants to merge 1 commit into
Open
Make ros2 action info --verbose consistent with topic/service info#1220catplotlib wants to merge 1 commit into
catplotlib wants to merge 1 commit into
Conversation
Signed-off-by: Puja Chaudhury <contact.pujachaudhury@gmail.com>
Author
|
@fujitatomoya can i get a review on this please? |
fujitatomoya
requested changes
May 14, 2026
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
this PR does not provide consistent format without --verbose option to print the action type just like ros2 topic info and ros2 service info do. i think this is format breaking change, but it would be nice to be consistent over the endpoint types.
how about introducing ActionEndpointInfo and call the corresponding rcl interface to get those information and client libraries such as rclpy and rclcpp call this API, including ros2action via rclpy. this is more consistent with other endpoint implementation, and all the client libraries can take advantage of this API?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
--verbose/-voption toros2 action info, matching the output style already provided byros2 topic info -vandros2 service info -v.Default output is unchanged. With
--verbose, each action client / server is printed as a block containing:CLIENT/SERVER)QoS and type hash are intentionally omitted since they are not exposed for action endpoints (per the linked issue).
Addresses the second TODO in #1210.
Is this user-facing behavior change?
Yes.
ros2 action infonow accepts--verbose/-v. Previously this flag was rejected as an unknown argument.Example (new behavior):
Without
-v, output is identical to before.Did you use Generative AI?
Yes — Claude Opus 4.7
Additional Information
ros2action/test/test_cli.py:test_fibonacci_info_verbose— asserts the verbose block fieldstest_fibonacci_info_verbose_count— asserts-v -csuppresses the per-endpoint block--verbosecombined with--countprints only the counts, matching the behavior ofros2 topic info -v -c.