Skip to content

Serialize encapsulation header on buffer aware topics#891

Open
MiguelCompany wants to merge 3 commits into
rollingfrom
miguelcompany/encapsulation-header-on-buffer-aware-topics
Open

Serialize encapsulation header on buffer aware topics#891
MiguelCompany wants to merge 3 commits into
rollingfrom
miguelcompany/encapsulation-header-on-buffer-aware-topics

Conversation

@MiguelCompany

Copy link
Copy Markdown
Collaborator

Description

While creating a native DDS consumer for rosidl buffer custom topics, I discovered that the encapsulation header required by the RTPS standard is not added for the reader-GUID-based topics.

This PR adds the encapsulation header when publishing, and consumes it when taking.

Is this user-facing behavior change?

No, but the custom serialization changes.
I would nonetheless consider backporting to lyrical.

Did you use Generative AI?

No.

Additional Information

I verified that the GPU buffer transport tutorial works with these changes

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany requested a review from nvcyc June 18, 2026 07:44

@wjwwood wjwwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I also think a backport is appropriate. Might need to run it by the PMC meeting and probably post about it to discourse.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

Pulls: #891
Gist: https://gist.githubusercontent.com/fujitatomoya/741ef888bcf594ff0daeabb85f8c6eb9/raw/ce2cf3f96a21ac1d898795b37ee193f062f8aa5f/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_fastrtps_cpp
TEST args: --packages-above rmw_fastrtps_cpp
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19595

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mergify

mergify Bot commented Jun 24, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@MiguelCompany

Copy link
Copy Markdown
Collaborator Author

@mjcarroll @sloretz As discussed in the PMC meeting, I added a log error for the version mismatch when reading the encapsulation header

@MiguelCompany MiguelCompany requested a review from sloretz June 24, 2026 09:21

@mjcarroll mjcarroll left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the note.

FYI @sloretz this is probably something that we want to announce when you do the next sync/patch.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany MiguelCompany force-pushed the miguelcompany/encapsulation-header-on-buffer-aware-topics branch from 375754d to 509fb5f Compare June 24, 2026 12:33
@MiguelCompany

Copy link
Copy Markdown
Collaborator Author

New CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants