add impl pointer for ExecutorOptions#2523
Merged
Merged
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
Member
Author
|
CI:
|
ahcorde
requested changes
May 9, 2024
ahcorde
left a comment
ahcorde
left a comment
Contributor
There was a problem hiding this comment.
Windows is failing, probably you are missing some RCLCPP_PUBLIC in the new class
Signed-off-by: William Woodall <william@osrfoundation.org>
Member
Author
|
Yup, I definitely did, but it should be fixed now, new CI:
|
clalancette
approved these changes
May 9, 2024
clalancette
left a comment
clalancette
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me with green CI.
marcoag
approved these changes
May 9, 2024
fujitatomoya
reviewed
May 9, 2024
fujitatomoya
left a comment
fujitatomoya
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me, test failures are unrelated? (currently CI is unstable?)
fujitatomoya
approved these changes
May 9, 2024
Contributor
Yeah, aarch64 is currently unstable. We can ignore those for now. |
ahcorde
approved these changes
May 9, 2024
Contributor
|
@Mergifyio backport jazzy |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
May 9, 2024
* add impl pointer for ExecutorOptions Signed-off-by: William Woodall <william@osrfoundation.org> (cherry picked from commit 343b29b)
clalancette
pushed a commit
that referenced
this pull request
May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #2505 (comment), we need this to potentially add more functionality to Jazzy post release, as well it gives us more flexibility to fix bugs in the future.
We already have this for the
Executor, so this class is the only one that needs adjustment:rclcpp/rclcpp/include/rclcpp/executor.hpp
Line 597 in f7185dc