Don't target release tags for dynrpm branches#772
Merged
Conversation
I wrote this code a long time ago so it's hard to remember, but it's likely I was trying to be clever by targeting the release tags instead of the release branches for the branching source when creating dynrpm branches. In theory, this would have allowed the dynrpm generator to be run without relying on the rosrelease generator running before it, but in practice it just broke the patching system. This commit aligns the branch matching function with the rpm and debian generators, restoring proper patch re-application and aligning the behavior with the existing generators.
mjcarroll
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote this code a long time ago so it's hard to remember, but it's likely I was trying to be clever by targeting the release tags instead of the release branches for the branching source when creating dynrpm branches. In theory, this would have allowed the dynrpm generator to be run without relying on the rosrelease generator running before it, but in practice it just broke the patching system.
This commit aligns the branch matching function with the rpm and debian generators, restoring proper patch re-application and aligning the behavior with the existing generators.