Skip to content

Replace deprecated ament_target_dependencies with target_link_libraries #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjcarroll wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace deprecated ament_target_dependencies with target_link_libraries #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions io_context/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
src/io_context.cpp
src/msg_converters/std_msgs.cpp
)
ament_target_dependencies(${PROJECT_NAME} "ASIO")
target_link_libraries(${PROJECT_NAME} PUBLIC "ASIO")

if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)
Expand All @@ -48,7 +48,7 @@ if(BUILD_TESTING)

ament_add_gtest(${TEST_UDP_DRIVER_EXE}
test/${name}.cpp)
ament_target_dependencies(${TEST_UDP_DRIVER_EXE} std_msgs udp_msgs "ASIO")
target_link_libraries(${TEST_UDP_DRIVER_EXE} PUBLIC std_msgs udp_msgs "ASIO")

target_include_directories(${TEST_UDP_DRIVER_EXE} PRIVATE include)
target_link_libraries(${TEST_UDP_DRIVER_EXE} ${PROJECT_NAME})
Expand Down
4 changes: 2 additions & 2 deletions serial_driver/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
src/serial_driver.cpp
)

ament_target_dependencies(${PROJECT_NAME} "ASIO")
target_link_libraries(${PROJECT_NAME} PUBLIC "ASIO")

ament_auto_add_library(${PROJECT_NAME}_nodes SHARED
src/serial_bridge_node.cpp
Expand All @@ -50,7 +50,7 @@ rclcpp_components_register_node(${PROJECT_NAME}_nodes
)

target_link_libraries(${PROJECT_NAME}_nodes ${PROJECT_NAME})
ament_target_dependencies(${PROJECT_NAME}_nodes "ASIO")
target_link_libraries(${PROJECT_NAME}_nodes PUBLIC "ASIO")

if(BUILD_TESTING)
find_package(ament_lint_auto)
Expand Down
6 changes: 3 additions & 3 deletions udp_driver/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
src/udp_socket.cpp
src/udp_driver.cpp
)
ament_target_dependencies(${PROJECT_NAME} "ASIO")
target_link_libraries(${PROJECT_NAME} PUBLIC "ASIO")

ament_auto_add_library(${PROJECT_NAME}_nodes SHARED
src/udp_receiver_node.cpp
src/udp_sender_node.cpp
)
ament_target_dependencies(${PROJECT_NAME}_nodes "ASIO")
target_link_libraries(${PROJECT_NAME}_nodes PUBLIC "ASIO")
target_link_libraries(${PROJECT_NAME}_nodes ${PROJECT_NAME})

rclcpp_components_register_node(${PROJECT_NAME}_nodes
Expand All @@ -62,7 +62,7 @@ ament_auto_add_executable(udp_bridge_node_exe
)

target_link_libraries(udp_bridge_node_exe ${PROJECT_NAME} ${PROJECT_NAME}_nodes)
ament_target_dependencies(udp_bridge_node_exe ASIO)
target_link_libraries(udp_bridge_node_exe PUBLIC ASIO)

if(BUILD_TESTING)
find_package(ament_lint_auto REQUIRED)
Expand Down