Depend on pkg-config where needed#281
Open
wentasah wants to merge 1 commit into
Open
Conversation
Packages audio_play and audio_capture need pkg-config, i.e. they have find_package(PkgConfig) in CMakeLists.txt. Therefore they should declare it as dependency.
Member
|
CI fails because of resolute package dependencies. |
Member
|
BTW, which build system are you working on? |
Author
|
I'm working with the Nix package manager. Its key property is that it builds packages in a sandbox, which contains only declared dependencies, nothing else. This helps in having reproducible builds. That's why I don't see the problem with rosdep dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packages
audio_playandaudio_captureneedpkg-config, i.e. they havefind_package(PkgConfig)inCMakeLists.txt. Therefore they should declare it as dependency.