Fix frame inconsistencies in pinocchio plugin#304
Open
justagist wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some frame consistency issues (wrt KDL implementation) in my original implementation of the pinocchio plugin.
Primarily, this addresses:
calculate_frame_differencewas computing the angular term different to how KDL does it, which would break any controllers that use this and expects the same behviour as the KDL plugin.Fixes #256
Is this user-facing behavior change?
Downstream code that compensated for the previous (incorrect) universe- /
local-frame behaviour will need to be updated. After this change the Pinocchio plugin
matches the KDL plugin, which is the documented and intended behaviour.
Did you use Generative AI?
Yes, Claude Code (Sonnet 4.6) was used for creating unit tests.
Additional Information
New tests created:
** (added to the sharedkinematics_interface_common_tests.hpp, so every plugin is checked): expects the angular velocity about+yin the base frame. Pre-fix Pinocchio returns it about+x` and fails; KDL passes.test_pinocchio_kdl_frame_consistency.cppcreated to make sure the results from pinocchio plugin matches KDL (used as oracle) when using default or custom base.TODOs
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)