Breadth-first search in report_iter#182
Open
Kile-Asmussen wants to merge 10 commits into
Open
Conversation
# Conflicts: # src/report/iter.rs # src/report/ref_.rs
- Drop unused `vec::Vec` import in src/report/iter.rs
- Rename marker types `DFS` -> `Dfs`, `BFS` -> `Bfs`
(clippy::upper_case_acronyms)
- Remove dead `generate_report_tree` and `join_contexts_as_string`
helpers — they had no callers and `format!("root")` triggered
clippy::useless_format
- Revert unrelated visibility bump `mod report` -> `pub(crate) mod report`
and drop misleading "Only importable in test" doc comment
TethysSvensson
force-pushed
the
feature/bfs
branch
from
ed0bdef to
6ed4360
Compare
Contributor
Author
|
Oh, I can see you deleted the dead code helper functions. With a good night's rest, I remember that I wrote them to deduplicate the code in the doctests. Dunno if that is very relevant, I thought they were quite verbose. Otherwise this looks fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.