[6.40] [ml] Fix out-of-bounds read in filtered cluster split#22441
Merged
guitargeek merged 1 commit intoJun 1, 2026
Merged
Conversation
In RClusterLoader::LoadTrainingClusterInto the boundary entry was read from rdfEntries unconditionally before checking valCount, so when one side of the split is empty the access was past end-of-vector. This was silent in non-hardened builds but trips libstdc++ assertions (e.g. with libcxxhardeningfast), aborting test09_filtered_last_chunk. Compute the boundary only when the corresponding rdfEntries index is in-bounds, falling back to the cluster endpoint otherwise. (cherry picked from commit 6183bad)
guitargeek
added
pr:backport
clean build
Test Results 22 files 22 suites 3d 9h 47m 1s ⏱️ Results for commit 9d8feb8. ♻️ This comment has been updated with latest results. |
guitargeek
merged commit 3f4f55d
into
root-project:v6-40-00-patches
44 of 65 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22440, requested by @guitargeek.