Fix TFile gap coalescing#19251
Draft
jblomer wants to merge 2 commits into
Draft
Conversation
Test Results 21 files 21 suites 3d 4h 49m 7s ⏱️ For more details on these failures, see this check. Results for commit 5389843. ♻️ This comment has been updated with latest results. |
jblomer
force-pushed
the
tfile-fix-gaps
branch
3 times, most recently
from
c0549c0 to
6449f14
Compare
silverweed
reviewed
Jul 9, 2025
pcanal
reviewed
Jul 15, 2025
pcanal
reviewed
Jul 15, 2025
jblomer
force-pushed
the
tfile-fix-gaps
branch
2 times, most recently
from
2e74c8e to
e0cecd7
Compare
Contributor
Author
|
... still some non-understood issues on recovery, working on that. |
1 task
jblomer
force-pushed
the
tfile-fix-gaps
branch
3 times, most recently
from
721bd0b to
5389843
Compare
Prevent merged free segments from becoming bigger than 2GB. Requires additional code to ensure that gaps at the end of the file are always merged.
This avoids tainting the recovered free list by stale entries that were read before. It also allows for stronger assertions in TFree::AddFree().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19245