Add support for number ranges #602
Conversation
Improve test
cargo fmt
|
Thanks @Ztry8 for prototyping this feature! |
|
Also, this addition will need to be documented in the grammar |
|
Thank you! I've already started working about this |
Add test for deserialising inside an untagged context
|
@juntyr, is everything fine now? What should I put into |
juntyr
left a comment
There was a problem hiding this comment.
Thank you for the changes, I left some further comments
|
Thank you! l've already started to working on this |
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
|
@juntyr, thanks for your help and support! I’ve implemented all of your suggestions. Could you please check? Sorry I didn’t commit some of your changes. |
|
It seems like you might need to refactor some imports from |
|
Thanks! l've already started to working on this |
Co-authored-by: Juniper Tyree <50025784+juntyr@users.noreply.github.com>
|
@juntyr, thank you for your cooperation! I’ve implemented all of your suggestions. What do you think about them? |
|
@Ztry8 Thanks for the progress! I'm a bit busy right now, can you fix CI, then I'll have the time for another full review. Thank you for all of your work! |
|
I've already started working on fixing the CI |
|
@Ztry8 It seems we're now getting to the tests for ranges but they are failing |
|
Yes, there are some issues that I'm currently fixing. |
|
@Ztry8 You shouldn’t add Cargo.lock directly - in CI we have the code that generated the lock file with maximum and minimum dependencies. If there’s a version conflict, you can look at that step to see how to fix up dependencies - often it’s resolved by using the correct version bound in Cargo.toml |
|
@juntyr, finding the root cause was quite tedious The CI uses a minimal-versions lockfile ( It turned out that Please let me know if bumping the serde minimum version is a problem Sorry for the noisy chore commits I've run CI on my fork and everything passes. |
This PR implements #601: support for number ranges in RON.
It's just syntactic sugar for structures with fields
start, endorstart, last.It supports both
std::opsandcore::range.Example: