Implement mempool.get_info Electrum RPC method#1292
Open
PeterXMR wants to merge 1 commit into
Open
Conversation
Adds support for the v1.6 `mempool.get_info` method introduced by the Electrum protocol. Forwards bitcoind's `getmempoolinfo` and returns the three fee-related fields the spec requires, in BTC/kvB: - mempoolminfee (dynamic, max of minrelaytxfee and mempool min) - minrelaytxfee (operator-configured) - incrementalrelayfee (optional; omitted when bitcoind does not expose it) Spec: https://electrum-protocol.readthedocs.io/en/latest/protocol-methods.html#mempool-get-info Refs romanz#1241
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1241 — checks off the
mempool.get_info()item on the v1.6 protocol checklist.Summary
Adds the new Electrum
mempool.get_infomethod introduced in protocol v1.6. Returns the three fee-related fields the spec requires, in BTC/kvB:getmempoolinfo)mempoolminfeemempoolminfeeminrelaytxfeeand mempool minimumminrelaytxfeeminrelaytxfeeincrementalrelayfeeincrementalrelayfeeThe JSON conversion is factored into a free function
mempool_info_to_jsonso the spec mapping can be unit-tested without an RPC client.Test plan
electrum::testscovering the JSON shape: full response, omitted optional field, zero feescargo test --lib— 24/24 passcargo clippy --all-targets -- -D warnings— cleancargo fmt --check— cleanMatches bitcoind's reported values: