Refactor image comparison region grouping#255
Open
Shourov735 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Description
This PR refactors internal image comparison logic without changing the public API or expected comparison output.
Changes included:
new Point(x, y)exclusion checks with coordinate-based checks.ImageComparisoninstance fields.ArrayDequetraversal.mergeRectangles()twice.Graphics2Dcolor state after filling rectangles.Related Issue
Closes #254
Motivation and Context
The comparison engine had some maintainability issues: temporary comparison state was stored on the
ImageComparisoninstance, region grouping used recursion, excluded-area checks allocated aPointobject for every pixel, and a few sentinel values were represented as magic numbers.This refactor keeps the behavior unchanged while making the comparison flow easier to maintain and safer for large connected difference regions.
How Has This Been Tested
Tested locally with:
mvn clean testmvn pmd:checkmvn pmd:cpd-checkmvn org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:testResults:
I also generated
mvn checkstyle:checkstyle. The repository still has existing broad Sun Checkstyle findings, so I did not include a full style-only rewrite in this focused refactor.Types of changes
Checklist