Skip to content

Commit 3960b5a

Browse files
authored
ci: align release app token usage (#82)
## Summary - remove the ineffective `owner` / `repositories` inputs from the release GitHub App token step - match the same-repo GitHub App token usage used in `oxc-project/oxc` and `oxc-project/unicode-id-start` - add `workflow_dispatch` so the release workflow can be manually retested after the GitHub App installation is fixed ## Why The failed run still reached `GET /repos/rolldown/notify/installation` and returned 404 even with `owner` and `repositories` set. The Oxc workflows use plain `client-id` + `private-key` for same-repo tokens; the remaining issue is the GitHub App installation or selected-repository access for `rolldown/notify`, not workflow token scoping. ## Verification - `ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "ok"'` - `git diff --check -- .github/workflows/release.yml`
1 parent 588c5ab commit 3960b5a

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

.github/workflows/release.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: Release
33
permissions: {}
44

55
on:
6+
workflow_dispatch:
67
push:
78
branches:
89
- main
@@ -21,10 +22,6 @@ jobs:
2122
with:
2223
client-id: ${{ secrets.APP_ID }}
2324
private-key: ${{ secrets.APP_PRIVATE_KEY }}
24-
owner: ${{ github.repository_owner }}
25-
repositories: ${{ github.event.repository.name }}
26-
permission-contents: write
27-
permission-pull-requests: write
2825

2926
- uses: oxc-project/release-plz@e2b12f55ad64a22af8e93634b94439c42913afca # v1.0.6
3027
with:

0 commit comments

Comments
 (0)