Skip to content

Commit 588c5ab

Browse files
authored
ci: scope release GitHub App token (#81)
## Summary - keep the release workflow on `actions/create-github-app-token` - scope the generated token through the repository owner installation and back to `notify` - request only the contents and pull request permissions needed by release-plz ## Why The release job failed before checkout because `actions/create-github-app-token` defaulted to the current repository lookup and GitHub returned 404 for `/repos/rolldown/notify/installation`. Setting `owner` and `repositories` makes the action create the token from the owner installation instead of relying on the repository-installation lookup path. ## Verification - `ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "ok"'` - `git diff --check -- .github/workflows/release.yml` `actionlint` is not installed locally, so it was not run.
1 parent aaadbf3 commit 588c5ab

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

.github/workflows/release.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ jobs:
2121
with:
2222
client-id: ${{ secrets.APP_ID }}
2323
private-key: ${{ secrets.APP_PRIVATE_KEY }}
24+
owner: ${{ github.repository_owner }}
25+
repositories: ${{ github.event.repository.name }}
26+
permission-contents: write
27+
permission-pull-requests: write
2428

2529
- uses: oxc-project/release-plz@e2b12f55ad64a22af8e93634b94439c42913afca # v1.0.6
2630
with:

0 commit comments

Comments
 (0)