Assignment Completed: Added Unit & Integration testing, fix pagination/priority bugs, implement task assignment endpoint - #51
Open
Adamkoda2306 wants to merge 23 commits into
Open
Conversation
…(page - 1) * limit
…se, fixed BUG 1 testcase
…fixed BUG 2 testcase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the reliability and maintainability of the Task Manager API by adding comprehensive automated tests, fixing identified bugs, and implementing a new task assignment feature.
Changes Made
✅ Added Unit Tests
Implemented 28 unit tests for the
taskServicecovering:✅ Added Integration Tests
Implemented 32 API integration tests using Supertest for all endpoints, including the new one:
GET /tasksGET /tasks?status=GET /tasks?page=&limit=POST /tasksPUT /tasks/:idDELETE /tasks/:idPATCH /tasks/:id/completePATCH /tasks/:id/assignGET /tasks/statsThe tests cover both successful requests and common error scenarios such as invalid input and missing resources.
✅ Bug Fixes
Pagination Bug
page * limitto(page - 1) * limitso the first page returns the correct records.Task Completion Bug
"medium".✅ New Feature
Implemented a new endpoint:
Features include:
404 Not Foundif the task does not exist.400 Bad Requestfor invalid or empty assignee values.Test Coverage
Coverage results:
A total of 60 automated tests have been added (28 unit, 32 integration), all of which are passing.
Testing
Executed:
Result: