Skip to content

extracting format-specific statements to dedicated classes#30

Open
LightSoar wants to merge 2 commits into
rohanisaac:masterfrom
LightSoar:hotfix/refactor-heirarchy
Open

extracting format-specific statements to dedicated classes#30
LightSoar wants to merge 2 commits into
rohanisaac:masterfrom
LightSoar:hotfix/refactor-heirarchy

Conversation

@LightSoar

Copy link
Copy Markdown

No description provided.

@LightSoar

LightSoar commented Feb 3, 2019

Copy link
Copy Markdown
Author

One obstacle for passing the tests in Python 3 is adding .encode():

s_32 = chr(int('0', 2))**.encode()** * 32
s_8 = chr(int('0', 2))**.encode()** * 8  # zero double

The test failed for Python 3 also because in Python 3 the float representation is longer than the one saved to the txt reference files.

Here's an example from Ft-ir.spc:
f1.data_txt() looks like this:

4000.0	95.13749694824219
3998.0	95.31822204589844
3996.0	95.56214904785156
3994.0	95.8303451538086

whereas dat = fin.read() looks like this:

4000.0	95.1374969482
3998.0	95.3182220459
3996.0	95.5621490479
3994.0	95.8303451538

not sure how to proceed.

@SoloIvan SoloIvan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactoring all project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants