fix crash when find the map's element which its defination in other f…#9
Open
tw4452852 wants to merge 1 commit into
Open
fix crash when find the map's element which its defination in other f…#9tw4452852 wants to merge 1 commit into
tw4452852 wants to merge 1 commit into
Conversation
Author
|
Assume there are two files: // 1.go
type A struct{}// 2.go
m := make(map[string]A)
if elm, ok := m["test"]; ok {
// do something
}if we find |
Owner
|
LGTM, thanks! Please fix conflicts and I will merge. |
…iles when we find a map's element which its defination is located in another file, it will crash. Signed-off-by: Tw <tw19881113@gmail.com>
Author
|
Done. |
| _, t := ctxt.exprType(expr, false, pkg) | ||
| if t.Kind == ast.Typ { | ||
| debugp("expected value, got type %v", t) | ||
| t = badType |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when we find a map's element which its defination is located in another file,
it will crash.
Signed-off-by: Tw tw19881113@gmail.com