Skip to content

Add -r for printing method receivers#105

Open
segevfiner wants to merge 1 commit into
rogpeppe:masterfrom
segevfiner:print-receivers
Open

Add -r for printing method receivers#105
segevfiner wants to merge 1 commit into
rogpeppe:masterfrom
segevfiner:print-receivers

Conversation

@segevfiner
Copy link
Copy Markdown

@segevfiner segevfiner commented Dec 26, 2018

Please consider if the format I'm printing these is OK:

foo.go:

package main

type Foo struct{}

func (f *Foo) bar() {

}

Running godef:

$ godef -t -r -f foo.go -o 52
foo.go:5:15
bar (*Foo) func()

Fixes #93
See: microsoft/vscode-go#2107

@segevfiner
Copy link
Copy Markdown
Author

@ramya-rao-a I will also be glad to hear what you think as we will have to parse this in vscode-go.

@ramya-rao-a
Copy link
Copy Markdown

The output looks good to me.

cc @rogpeppe @ianthehat

segevfiner added a commit to segevfiner/vscode-go that referenced this pull request Dec 31, 2018
segevfiner added a commit to segevfiner/vscode-go that referenced this pull request Jan 8, 2019
segevfiner added a commit to segevfiner/vscode-go that referenced this pull request Jan 9, 2019
ramya-rao-a pushed a commit to microsoft/vscode-go that referenced this pull request Jan 9, 2019
…umentation (#2223)

* Use the newly added receiver output from godef to get the correct documentation

See rogpeppe/godef#105

Part of #2107

* Review fixes
@segevfiner
Copy link
Copy Markdown
Author

ping @rogpeppe @ianthehat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants