build!: update MSRV 1.53.0#1
Open
kolbma wants to merge 8 commits into
Open
Conversation
Dependency multer -> spin doesn't build below rust 1.51.0 which seems to be related to * atomic::spin_loop_hint has been deprecated. It's recommended to use hint::spin_loop instead.
resolving fails below because of crate time
cargo resolving fails below because of crate time
|
Should we keep msrv as low as possible with rust 2018 or rust 2021? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the minimum required rustc version to 1.53.0.
Below it doesn't make sense, because not all parts and tests of Rocket would compile.
There follows another PR to patch some little things to get all tests run also with MSRV and nightly.