Improve support for older CMake versions with stricter interface lib …#99
Open
m0rsch1 wants to merge 4 commits into
Open
Improve support for older CMake versions with stricter interface lib …#99m0rsch1 wants to merge 4 commits into
m0rsch1 wants to merge 4 commits into
Conversation
…handling Signed-off-by: Moritz Schilling <moritz.schilling@dfki.de>
chhtz
requested review from
doudou,
pierrewillenbrockdfki,
planthaber and
skasperski
planthaber
approved these changes
Jun 15, 2026
pierrewillenbrockdfki
requested changes
Jun 15, 2026
pierrewillenbrockdfki
left a comment
pierrewillenbrockdfki
left a comment
Contributor
There was a problem hiding this comment.
This adds support for targets of TYPE INTERFACE_LIBRARY, i think that exists elsewhere as well. That seems fine. What is blindingly obvious in the online diff is: the indentation does not match the surroundings and is not consistent with itself. Please fix that(replace TAB with 8 spaces).
chhtz
reviewed
Jun 15, 2026
skasperski
approved these changes
Jun 17, 2026
chhtz
approved these changes
Jun 17, 2026
pierrewillenbrockdfki
approved these changes
Jun 17, 2026
pierrewillenbrockdfki
left a comment
pierrewillenbrockdfki
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…handling
Older CMake versions want some properties like INCLUDE_DIRECTORIES to be prefixed with INTERFACE_
Otherwise they throw an error.
This fixes some issues with orocos-cpp and backward-cpp during build process on OSes with older CMake Versions (like e.g. Ubuntu 20.04)