test: sweep blueprints at runtime seeds; make task versions explicit#25
Merged
Conversation
Post-merge cleanups from the #24 review: - test_sim_blueprint's sweep paired scenes with derive_seed(0, index, epoch), seeds that no longer occur at runtime now that init_seed is crc32-derived. Sweep with derive_seed(0, scene.init_seed, epoch) instead. Pinned tests keep their fixed seed literals (they check blueprint/realization consistency at a seed, any seed); the one comment claiming those literals were real epochs is reworded. - TaskSpec.version's default was bumped to "2" in #24, which would mint future new tasks at version 2. Restore the default to "1" and set version="2" explicitly on the nine existing tasks (scoop_pasta already pins "3"). Realized version stamps are unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the fresh-eyes review of #24 (both flagged as non-blocking nits there). No behavior change to shipped scenes.
What
tests/test_sim_blueprint.py: the parametrized soundness sweep still paired every scene withderive_seed(0, index, epoch)— index-derived seeds that never occur at runtime since fix: derive scene seed from instance_id, not sorted index #24. It now sweepsderive_seed(0, scene.init_seed, epoch), the seeds a default eval actually uses. The pinned tests keep their exact seed literals and assertions (they verify blueprint↔realization consistency at a fixed seed, which is seed-agnostic); the one comment claiming those literals correspond to real epochs is reworded.src/kitchenbench/specs.py: fix: derive scene seed from instance_id, not sorted index #24 bumped theTaskSpec.versiondefault to"2", so a genuinely new task would be born at version 2. The default is back to"1"and the nine existing tasks now pinversion="2"explicitly (scoop_pastaalready pins"3"). Every realized scene stamps the same version as before — verified by the existing metadata tests.Gates
ruff checkclean,ruff format --checkclean,mypyclean, 317/317 pytest with the 100% coverage gate met.🤖 Generated with Claude Code