faSplit -outDirDepth - #18
Open
AngieHinrichs wants to merge 1 commit into
Open
Conversation
… current directory when running on 100k sequences. Don't use inputdir to find split files because they are in current directory which may not be inputdir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running with a large number of sequences (which I realize is no longer the norm for you Rob, but some of us may need to when starting out), it's nice to use a temporary directory and faSplit's -outDirDepth=N option so that a large number of files aren't added in a single directory.
Also, inputdir was used as the location of the temporary files when concatenating, but faSplit creates them in the current directory (unless otherwise specified), so that would fail if inputdir were not the current directory.
If you approve of this, FYI I also plan to add the use of ${TMPDIR} if defined as the location of the temporary files.
Thanks!
Angie