fix(components/ImagePreviewer): Prevent from negative top position#55
Open
mingyc wants to merge 1 commit into
Open
fix(components/ImagePreviewer): Prevent from negative top position#55mingyc wants to merge 1 commit into
mingyc wants to merge 1 commit into
Conversation
Example Bug: https://i.imgur.com/8hJoZTD.png The current returned top position calculated by (pageHeight - 20 - height) can be negative, leading to part of the image rendered outside the screen. This commit fixes it by verifying if the difference of windows height & image height is valid before returning. A better fix would be resizing the image whenever necessary, which is out of the scope of this commit.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example Bug: https://i.imgur.com/8hJoZTD.png
The current returned top position calculated by (pageHeight - 20 -
height) can be negative, leading to part of the image rendered outside
the screen. This commit fixes it by verifying if the difference of
windows height & image height is valid before returning.
A better fix would be resizing the image whenever necessary, which is
out of the scope of this commit.