feat: add circular dependency detection with PodCycleError#5
Merged
Conversation
Detect cycles during provider resolution and throw a descriptive PodCycleError with the full dependency chain. Providers can now include an optional debugName for clearer diagnostics; unnamed providers display as Provider<T> in error messages. Changes: - Add PodCycleError with cycle chain and human-readable toString - Add debugName parameter and debugLabel getter to Provider - Track resolution stack in Pod to detect cycles - Add tests for cycle detection and concurrent async resolves Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PodCycleErrordebugNameparameter toProviderfor clearer diagnostics in error messagesProvider<T>in cycle error chains (e.g.,A -> Provider<String> -> C -> A)Changes
lib/src/errors.dartPodCycleErrorclass with cycle chain and human-readabletoStringlib/src/provider.dartdebugNameparameter anddebugLabelgetterlib/src/pod.dartresolve()lib/dartypod.darterrors.darttest/pod_test.dartCHANGELOG.mdTest plan
dart testpasses (44 tests)dart analyze --fatal-infospassesdart formatappliedMade with Cursor