fix: adds rate limiting, email validation, password max [#53]#65
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flask-Limiterrate limits onPOST /loginandPOST /register8-128charactersuser_id = count() + 1race by retrying registration on unique-key conflicts while preserving the existinguser_id-based schemacourseIDexists before creating an enrollment/logoutPOST-only and move the nav logout action to a CSRF-protected form100%Python coverageNotes
user_id-based enrollment/session flow intact instead of migrating the app to Mongo_id, which avoids a larger schema and seed-data change while still addressing the registration race condition.Testing
docker compose exec course-enrollment-app python -m pytestdocker compose run --rm e2e-testspre-commit run --files application/__init__.py application/forms.py application/routes.py tests/conftest.py tests/test_routes.py requirements.txtpre-commit run --files application/forms.py application/routes.py application/templates/includes/nav.html tests/test_routes.py e2e/ui-walkthrough.spec.jspre-commit run --files tests/test_routes.py AGENTS.mdmake codecovCloses #53