MainActivity: catch ActivityNotFoundException in WebView URL handoff#15
Open
jim-daf wants to merge 1 commit into
Open
MainActivity: catch ActivityNotFoundException in WebView URL handoff#15jim-daf wants to merge 1 commit into
jim-daf wants to merge 1 commit into
Conversation
MyWebViewClient.shouldOverrideUrlLoading forwards every URL the embedded HTML page navigates to with a plain startActivity(Intent. ACTION_VIEW). If the device has no installed app that handles the URI (a tablet without a browser, a stripped GSI build, a tel: link on a non-phone form factor, ...), startActivity throws ActivityNotFoundException and the Activity is torn down mid-game. Wrap the launch in try / catch and surface a Toast so a missing handler scopes the failure to that single click instead of crashing the whole Activity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #14.
Summary
MyWebViewClient.shouldOverrideUrlLoadingcallsstartActivity(Intent.ACTION_VIEW, uri)with notry / catch. On a device that has no handler for the URI scheme, that throwsActivityNotFoundExceptionand crashes the Activity mid-game. This PR wraps the launch and falls back to a Toast.Changes
MainActivity.java-- importActivityNotFoundExceptionandToast; wrap thestartActivitycall intry / catch; log the failure and showNo app to open this link.Test plan
http(s)link the game might surface on a device with a browser -- browser opens, game pauses as before.http(s)link on an emulator withcom.android.chromedisabled -- Toast appears, game keeps running.