ci: expose rmk_version input and scope the push trigger - #2
Open
HaoboGu wants to merge 1 commit into
Open
Conversation
Surface the reusable workflow's rmk_version input via workflow_dispatch so forks can build against a released RMK version (default: main); previously every fork was stuck on main because this file never passed it through. Scope the push trigger to keyboard.toml/vial.json so README/other edits don't trigger a firmware rebuild. Add a README covering cloud builds and the version knob.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes the RMK version selectable in cloud builds, and stops rebuilding firmware on unrelated edits.
Changes
rmk_versioninput — the reusable workflow (haobogu/rmk/.github/workflows/user_build.yml) already acceptsrmk_version, but this template never surfaced it, so every fork was pinned tomain.workflow_dispatchnow exposes it (defaultmain) and threads it through; pushes stay onmain.pushtrigger — waspaths: ["**"](rebuilt on any file, including README edits). Now onlykeyboard.toml/vial.json.Existing forks are unaffected: the input is optional and defaults to
main.