fix(swarm): fix deploy key, metadata, and branch collisions for private tasks#57
Open
lolismek wants to merge 1 commit into
Open
fix(swarm): fix deploy key, metadata, and branch collisions for private tasks#57lolismek wants to merge 1 commit into
lolismek wants to merge 1 commit into
Conversation
…te tasks When running `hive swarm up` on a private task, all agents clone the same repo in branch mode. Three bugs caused agents to interfere with each other: 1. Deploy key filename derived from ssh_url was identical for all agents, causing each agent to overwrite the previous one's key file. 2. .hive/ metadata was written before `git checkout`, so checkout could overwrite it with stale data. Also .hive/ was not gitignored. 3. If the remote branch didn't exist yet, checkout failed silently and the agent stayed on main. Fixes: include agent_id in key filename, move metadata writes after checkout, add .hive/ to .gitignore, and fall back to `checkout -b` when the branch doesn't exist on the remote.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ssh_url, which is identical for all agents). Now includesagent_idin the filename..hive/agentand.hive/taskwere written beforegit checkout, so checkout could clobber them. Moved writes to after checkout. Also adds.hive/to workspace.gitignore.git checkoutfailed silently and the agent stayed onmain. Now falls back togit checkout -b.Test plan
_apimocked)