Feature gate job deletions#582
Open
adelowo wants to merge 3 commits into
Open
Conversation
Author
|
just noticed #546 while we were trying to upgrade docker tag. While 546 goes a step further, this pr removes the possibility of fat fingering ever |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we recently had an issue where I did not notice I was on the prod instance not local version and I deleted a bunch of jobs. This makes it easier to remove all form of human errors.
This PR adds a new env value
FEATURE_JOB_DELETION_DISABLED=true|falsethat disables/enables the deletion api and UI button.It defaults to false to keep the existing behaviour where the jobs can be deleted