Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds MPI detection capability to the MPIHandler class and enforces MPI requirement for the QBC application. The changes introduce an isMPI() method that returns True for the real MPI implementation and False for the no-MPI mock implementation, and adds a check in QBC's initialization to ensure MPI support is available.
Key Changes
- Added
isMPI()method to both MPI handler implementations to distinguish between real and mock MPI support - Added MPI availability check in QBC application initialization that raises an
ImportErrorwhen MPI is not available
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| qstone/multiprocessing/nompi.py | Adds isMPI() method returning False to indicate no MPI support |
| qstone/multiprocessing/mpi.py | Adds isMPI() method returning True to indicate real MPI support |
| qstone/apps/QBC.py | Adds MPI availability check in __init__ that raises error when MPI is unavailable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #78.
Rationale:
pip install QStone[mpi]This PR raises an exception if users try to run QBC apps without MPI.