Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds enhanced tracing/logging and significant refactors to the RB and QBC applications, including new configuration handling, schema changes, and benchmarking logic. Also updates connector tracing steps, modifies the mock MPI handler, and relaxes Pandera import usage. Some test assertions were removed without replacement.
- Refactored RB app: new schema, benchmark generation, QASM construction, and survival probability aggregation.
- Refactored QBC app: added argument decoding, parameter initialization changes, and updated loss aggregation.
- Introduced (insecure) pickle-based APP_ARGS decoding in both RB and QBC; removed RB test assertions reducing coverage.
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_apps.py | Removed assertions in RB pre test reducing validation strength. |
| qstone/utils/utils.py | Added docstring and minor membership check improvement. |
| qstone/profiling/profile.py | Adjusted pandera import namespace. |
| qstone/multiprocessing/nompi.py | Added communicate method; changed Get_size return; simplified allreduce. |
| qstone/generators/generator.py | Added formatting newline (no functional change). |
| qstone/generators/common/jobs.py.jinja | Updated connector argument/environment variable mapping and removed duplicate instantiations. |
| qstone/connectors/no_link/no_link.py | Corrected computation_step annotations; switched outcome source. |
| qstone/apps/RB.py | Major redesign of RB workflow, configuration parsing, QASM generation, and post-processing. |
| qstone/apps/QBC.py | Added tracing levels, APP_ARGS decoding, parameter initialization changes, and loss logic adjustments. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
…he RB and QBC apps on the README file
Pip has a vulnerability that cannot be mitigate for python <3.10.10. It does not really affect recent users (running on 3.10.15).
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 11 out of 13 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tracing with larger logging levels to both the QBC and RB apps