Fix trailing whitespace in CONTRIBUTING.md#103
Merged
Conversation
The trailing-whitespace pre-commit hook fails on a fresh checkout (and on every repo generated from this template) because CONTRIBUTING.md carries trailing whitespace. Strip it so the pre-commit job is green out of the box. Signed-off-by: Rafael Sene <rafael@riscv.org>
Rafael Sene (rpsene)
force-pushed
the
fix/contributing-trailing-whitespace
branch
from
fc0f88e to
689963a
Compare
Bill Traynor (wmat)
left a comment
Bill Traynor (wmat)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Rafael.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trim trailing whitespacepre-commit hook fails on a clean checkout of this template, and therefore on every repository generated from it (the hook modifiesCONTRIBUTING.mdand pre-commit exits non-zero).This strips the two offending trailing-whitespace occurrences in
CONTRIBUTING.mdsopre-commit run --all-filespasses out of the box and newly generated spec repos start with a green CI.Whitespace-only change; verified
pre-commit run --all-filespasses afterward.