10857 voucher error moving between summary and cart take2#2
Open
dacook wants to merge 5 commits into
Conversation
I'm not sure if it will ever make a difference, but I think this makes more sense.
Maybe there was a reason we don't do this, but it seems like the best way to solve the problem to me. I'd like Gaetan to review this.
I'm not sure if we need to refresh other adjustments, but it seems worth being comprehensive. Alternatively we could probably call just order.update_totals.
dacook
force-pushed
the
10857-voucher-error-moving-between-summary-and-cart-take2
branch
from
48b07a1 to
782b37d
Compare
Author
|
@rioug can you please review this after reading Konrad's comments, and apply it, if it makes sense to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What? Why?
Regarding Konrad's comments here: openfoodfoundation#11117 (comment)
What should we test?
I think this pertains to all of Konrad's comments.
I'm not sure if it will solve the tax calculation issues; we probably need to add specs for those too.
Dependencies