fix(tests): clear test-floor to zero failures (15 → 0)#70
Merged
Conversation
After PRs #65–#68 merged, the pre-existing-failure floor was 15 (11 failures + 4 errors / 637 tests). All 15 were either UX-pass template-string drift (sentence vs. title case, retitled headings), behavior drift (anon trial removed login gate), or missing fixture paths. None were real bugs. Categories: - test_anonymous_trial.test_anon_grade_page_shows_trial_banner (1) Asserted "Trial mode" — no template renders that string anywhere. Switched to "free grades left", which the banner does render. - test_feedback (5) Title-case → sentence-case across submit form heading, update heading, and analytics page heading. test_feedback_button_in_results asserted "Provide Feedback" but the actual button on grade_results is labeled "Detailed feedback" (links to the same submit_feedback URL). - test_integration (3, legacy) - test_authentication_required: /grade/ is no longer login-gated (anon trial flow); only history/account/connections require auth. - test_full_query_grading_workflow: "Query Analysis Results" retitled to "Grade results" in the UX pass. - test_grade_display_formatting: grade-{letter} CSS class was retired; grade pill now uses Tailwind utilities. Assert visible grade letter directly. - test_database_analysis.test_database_analyze_get (1) Page heading retitled "Database Architecture Analysis" → "Connect a database" (#54 connection-mgmt UI). - test_optimization.test_optimization_integration_workflow (1) Optimization section + tab labels lowercased and shortened. - analyzer.tests.ParserTestCase (4 errors) setUp() looked for sample logs under analyzer/samples/ but they live at the repo-root samples/ dir. Fixed the path computation. After this change: `python manage.py test analyzer` → 637 tests, 0 failures, 0 errors, 14 skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After the tech-debt sweep (#65–#68) merged, the test suite floor was 15 failures (11 fail + 4 error / 637 tests). All 15 were either UX-pass template-string drift, behavior drift, or a missing fixture path — none were real bugs.
After this PR: 0 failures, 0 errors, 14 skipped (project default).
What was fixed
Test plan