fix(ddd): Normalize Email value object to lowercase#75
Merged
Conversation
Store email addresses in lowercase so differently cased inputs compare equal. Expand Email VO tests for validation errors and normalization. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: eee7b25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emailinputs to lowercase in the constructor so mixed-case addresses are stored consistentlyequals()EmailVO tests for validation errors, metadata, and lowercase normalization@rineex/dddpatch changesetMotivation
Email local parts are case-insensitive per RFC 5321. Normalizing on construction avoids duplicate identities and inconsistent comparisons when users enter addresses with different casing.
Test plan
Emailunit tests pass (14 tests, including lowercase normalization and case-insensitive equality)Made with Cursor