Show error when your filter file isn't present#212
Open
Kaqemeex wants to merge 3 commits into
Open
Conversation
... on the machine that you tried to load it on.
Kaqemeex
commented
Jul 19, 2026
| @@ -1,15 +1,11 @@ | |||
| package com.lootfilters; | |||
|
|
|||
| import com.lootfilters.lang.CompileException; | |||
Collaborator
Author
There was a problem hiding this comment.
Removed unused imports.
Kaqemeex
commented
Jul 19, 2026
| filterDescription = new JTextArea(); | ||
| filterDescription.setEditable(false); | ||
| filterDescription.setLineWrap(true); | ||
| filterDescription.setWrapStyleWord(true); |
Collaborator
Author
There was a problem hiding this comment.
Much cleaner rendering when the text breaks on words rather than any char.
Kaqemeex
force-pushed
the
kq/missing-file-warning-2
branch
from
July 19, 2026 19:12
fb20989 to
42eaeb0
Compare
Kaqemeex
force-pushed
the
kq/missing-file-warning-2
branch
from
July 19, 2026 19:17
42eaeb0 to
e58804a
Compare
Kaqemeex
commented
Jul 19, 2026
| try { | ||
| return doLoadFilter(); | ||
| } catch (Exception e) { | ||
| } catch (IOException e) { |
Collaborator
Author
There was a problem hiding this comment.
This then doesn't wrap the FilterNotFoundException; making finding it easier later (ie it's the direct cause of the completion exception rather than CompletionExeption(RuntimeException(FilterNotFoundException(...)))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... on the machine that you tried to load it on.