Skip to content

add a public get_tree() method and have print_tree use it#83

Open
tupshin wants to merge 2 commits into
riker-rs:masterfrom
tupshin:master
Open

add a public get_tree() method and have print_tree use it#83
tupshin wants to merge 2 commits into
riker-rs:masterfrom
tupshin:master

Conversation

@tupshin

@tupshin tupshin commented Jan 31, 2020

Copy link
Copy Markdown

Note that I found this useful when debugging and I didn't have access to a
normal stdout.

Note that I found this useful when debugging and I didn't have access to a
normal stdout.
@hardliner66

hardliner66 commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

I don't think exposing a string representation of the internal state is a good idea.

It would be better to just change the println! calls with debug! calls from the log crate. This way you could add a different log targets depending on your needs, without exposing internal state.

@olexiyb

olexiyb commented Apr 11, 2020

Copy link
Copy Markdown
Contributor

merged it into actors.rs

@leenozara

Copy link
Copy Markdown
Contributor

Hi @tupshin thanks for the input. I think you've identified a valid problem, however @hardliner66 has a valid point re not using a string representation. My concern would be larger actor systems that have several thousand or more actors and the allocation to append each actor name. Maybe there is a more effective way to solve the problem that you've identified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants