Fix slow installer upgrades and refresh dependencies - #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the installer upgrade phase that appeared to grow indefinitely on systems with an existing legacy Nemotron installation. It also refreshes Wails and other compatible application dependencies so Parley picks up fixes published since the currently pinned versions.
Installer upgrade fix
Root cause
The upgrade was not downloading or reinstalling Nemotron. After the application files and shortcuts were already installed, Wails' generated
wails.writeUninstallermacro recursively scanned the entire$INSTDIRtree to calculate the Windows Add/Remove ProgramsEstimatedSizevalue.Older Parley releases stored the optional Nemotron model, Python runtime, package cache, and supporting files below
$INSTDIR\resources\nemotron. A preserved legacy installation can contain more than 10 GB and tens of thousands of files. Consequently, the final bookkeeping scan took several minutes, continually increased the displayed Size/Files/Folders counters, and ran during a phase where the NSIS Cancel button was unavailable.Resolution
EstimatedSizefrom only the shipped Parley executable and bundled CPU Whisper resources.wails.writeUninstallercall and any recursive${GetSize} "$INSTDIR"scan in Parley's installer.This does not move, delete, reinstall, or otherwise modify an existing Nemotron installation.
Dependency updates
v3.0.0-alpha2.109v3.0.0-alpha2.117v3.0.0-alpha2.109v3.0.0-alpha2.1173.0.0-alpha.953.0.0-alpha.97golang.org/x/sysv0.44.0v0.47.0modernc.org/sqlitev1.53.0v1.54.08.1.08.1.54.3.14.3.31.21.01.24.0The lockfile also picks up compatible Radix and transitive patch/minor releases selected by the existing semver ranges. Wails bindings were regenerated with the matching alpha2.117 CLI; the only semantic generated change synchronizes an existing settings-field comment.
React 18 and TypeScript 5 were intentionally retained. Moving to React 19 or TypeScript 7 would be a separate major-version migration with a wider compatibility and behavioral review surface, and neither is required for this Wails update.
CI continues to use
npm installrather thannpm ci: Tailwind's bundled optional WASM dependencies currently cause npm to reject its own generated lockfile as missing nested optional packages during a clean install.Validation
go test -count=1 ./...go vet ./...npm run build(TypeScript and Vite production build)v3.0.0-alpha2.117git diff --checkNSIS is not installed on the development workstation, so the release workflow remains the compiler-level Windows installer packaging gate. The custom macro uses standard documented NSIS
GetSize,FileOpen,FileSeek, registry, and uninstaller commands.