fix(diff): separate every bulk header block with a blank line#34
Merged
Conversation
Inside a turn, a submodule's "▸ parent › child" hand-off (and a bare target change) printed glued to the end of the diff above it — only the turn banner was set off by a blank line. So a breadcrumb sitting between two diffs got lost in the surrounding diff text. Lead every header block with a blank line, not just the turn banner: move the separator out of diffTurnBanner and into the callers (DiffCollector.Print and DiffHeader), emitted whenever a new header block starts. The rendered header bytes are otherwise unchanged, so full mode and the single-module path are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #33. The module breadcrumb between diffs wasn't visible enough: inside a turn, a submodule's
▸ parent › childhand-off (and a bare target change) printed glued to the end of the diff above it — only the turn banner was set off by a blank line. So a breadcrumb sitting between two diffs got lost in the surrounding diff text.This leads every header block with a blank line, not just the turn banner — the separator moves out of
diffTurnBannerand into the callers (DiffCollector.PrintandDiffHeader), emitted whenever a new header block starts.Before (within a turn)
After
The rendered header bytes are otherwise unchanged, so full mode and the single-module path are unaffected.
Testing
go build ./...,go vet ./..., fullgo test ./...— all green.TestDiffCollector_BannerOncePerTurnHandoffPerSubmodule.🤖 Generated with Claude Code