feat: Support spaCy 3.7-3.8; Python 3.12#41
Conversation
|
Is there any hope of this actually being merged? The last commits on master were 3 years ago... |
Not sure. I'm going to see if I can contact the author directly. Failing that, I can try publishing a separate package. You're welcome to give it a sanity check :) |
|
Hi @DanielSchaffer, thankyou very much for all your work! I'm no longer actively working on Coreferee, but I'm glad people are finding it useful and will definitely do my best to get this merged. On the individual points you raise:
|
|
Zip files make sense. For 3.8, I've actually resolved that - I just hadn't had the chance to make sure tests were passing on both 3.7 and 3.8, but that's done now. For French, my colleague @eugenielm has offered to take a look, though if @Pantalaymon has some time to review that would be great as well. |
Description
Internal changes and fixes
importlib.resourcesinstead ofpkg_resourcesfor Python >= 3.9.pyproject.toml.Addresses #29
I'm not sure if anyone is still monitoring this repo. This isn't quite ready to merge, but I'd appreciate if someone could start taking a look, as there were some changes necessary specifically to support spaCy v3.7+
TODO
.zipfilesModel
.zipfilesThe
enzip now exceeds 100MB, which is GitHub's limit for public repositories. Beyond that, you'd need to usegit-lfs, but I'm not sure what's involved in setting that. I don't think it's free. Are they used for anything beyond a convenience download?