Skip to content

DO NOT MERGE, test: see if github actions changes run #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaron-prindle wants to merge 1 commit into
base: hackathon
Choose a base branch
from
Open

DO NOT MERGE, test: see if github actions changes run #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/gemini-pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,6 @@ jobs:
PR_NUMBER: ${{ github.event.pull_request.number }}
GITHUB_REPOSITORY: ${{ github.repository }}
run: python ./hack/gemini_review.py

@github-actions github-actions Bot Feb 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is named "Test modifications" which is vague. It should be renamed to something more descriptive of what it actually tests, or removed if it's not a meaningful test.

- name: Test modifications

@github-actions github-actions Bot Feb 19, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step "Test modifications" seems unnecessary and doesn't contribute to the core functionality of the workflow (API review). Consider removing it unless it serves a specific debugging or testing purpose during development of the GitHub Action itself. If it's for debugging, add a comment explaining why.

run: echo "Test to see if github actions modifications run"