Skip to content

Set artifacts_links in final results in testing farm workflow#94

Merged
velezd merged 2 commits into
develfrom
tf_fix
Jun 8, 2026
Merged

Set artifacts_links in final results in testing farm workflow#94
velezd merged 2 commits into
develfrom
tf_fix

Conversation

@velezd

@velezd velezd commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

This fixes missing links in Polarion reporting.

@velezd velezd requested review from PLukas2018 and jstodola June 5, 2026 13:23
@velezd

velezd commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator Author

@jstodola this will change the "Comment" content in results pushed to Polarion. I don't know if you have any automation that is reading it.

@PLukas2018

Copy link
Copy Markdown
Collaborator

Claude thinks that there could be a bug:

Commit 9cedefb — Set artifacts_links in final results

Bug: self.weblink can be None at result-reporting time.

self.weblink starts as None and is only set if status['run']['artifacts'] is reachable (lines 151–155, wrapped in a try/except that silently swallows failures). If
Testing Farm errors or cancels before that field is populated, self.weblink is still None.

The new code then passes artifacts_links=[None] to Result(). In descriptionOf() (base.py:244–248):

', '.join([link for link in crc.result.extra_fields.get('artifacts_links', ['None'])])

The default ['None'] (string) only applies when the key is absent. When it's present as [None] (Python None), str.join raises TypeError: sequence item 0: expected str
instance, NoneType found.

Fix:
artifacts_links=[self.weblink] if self.weblink else []

Or filter in base.py:
', '.join([str(link) for link in crc.result.extra_fields.get('artifacts_links', []) if link is not None]) or 'None'

Otherwise LGTM.

PLukas2018
PLukas2018 previously approved these changes Jun 8, 2026

@PLukas2018 PLukas2018 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

velezd added 2 commits June 8, 2026 10:16
We now have more than beaker workflow, so the description in base
reportsender should be more generic.
@velezd velezd merged commit 544815a into devel Jun 8, 2026
4 checks passed
@velezd velezd deleted the tf_fix branch June 8, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants