Improve failure mode in Beaker installations during provisioning#70
Merged
Conversation
to make more clear why Beaker fails to start if it's not possible to get the FQDN (e. g. only a plain hostname is resolved). Also print the requested URL in http_get() for debug purposes. Assisted-by: Cursor
so that Anabot doesn't erroneously upload log files to unrelated task if the first task is not related to Anabot, and also make Anabot fail right at the beginning of its execution to make the issue more clear. Assisted-by: Cursor
jstodola
approved these changes
Jun 11, 2026
jstodola
left a comment
jstodola
left a comment
Collaborator
There was a problem hiding this comment.
It looks good to me, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is basically related to improperly setup Beaker jobs where Anabot is running during the very first installation (system provisioning). Even though Anabot would fail even without this improvement in the end, it's better to get a more directed error message, so that it's easier to review the failed jobs if a job misconfiguration occurs in the future.
It addresses the following situations:
ANABOT_RECIPE_URLparameter (the Anabot recipe is always taken from the task parameter when running in Beaker)INTERACTIVE_KICKSTARTparameter (provisioning is always kickstart-driven)Moreover, the change adds a debug message for
http_get()function and makes the Beaker module raise an exception if the system's hostname couldn't be fully determined (as FQDN).