Skip to content

feat: make OpenCode the default DevSpaces IDE - #20

Merged
itay1551 merged 5 commits into
mainfrom
feat/opencode-default-ide
Jul 29, 2026
Merged

feat: make OpenCode the default DevSpaces IDE#20
itay1551 merged 5 commits into
mainfrom
feat/opencode-default-ide

Conversation

@itay1551

Copy link
Copy Markdown
Collaborator

Summary

  • Make OpenCode the default IDE across chart defaults, ARO/ROSA values, and existing-OpenShift (TYPE=opencode; Continue via TYPE=continue)
  • Soft-skip Continue/Roo smoke ConfigMap checks when those resources are absent on OpenCode workspaces
  • Update README, IDE docs, existing-OpenShift guide, and deploy skill to match

Commits

  1. feat: make OpenCode the default DevSpaces IDE
  2. test: skip Continue/Roo smoke checks on OpenCode workspaces
  3. docs: document OpenCode as the default IDE

itay1551 added 3 commits July 29, 2026 12:09
Flip chart and existing-OpenShift defaults to OpenCode while keeping Continue as TYPE=continue.
Soft-skip ConfigMap assertions when those resources are absent for OpenCode.
Align README, IDE guide, existing-OpenShift docs, and deploy skill with the new default.
@itay1551
itay1551 requested a review from Hadar301 July 29, 2026 09:11

@Hadar301 Hadar301 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR!

opencodeBuild:
enabled: false
devspaces:
- name: code-workspace-1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYPE=continue silently deploys with wrong Langfuse user. user: dev-user1 is a hardcoded placeholder. The Makefile enforces DEV_USER only when TYPE=opencode; a developer running make devspace-deploy-existing-openshift DEV_NAMESPACE=foo TYPE=continue without DEV_USER will deploy successfully with dev-user1 as the Langfuse attribution user — no error, no warning.

Add the same guard to the Makefile for the continue path: @if [ "$(TYPE)" = "continue" ] && [ -z "$(DEV_USER)" ]; then echo "ERROR: DEV_USER is required for TYPE=continue. Pass DEV_USER="; exit 1; fi

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: DEV_USER is now required for both opencode and continue (no continue escape hatch). It always sets devspaces[0].user so Langfuse X-PCA-User and the edit RoleBinding match the real developer.

Comment thread Makefile
N ?= 4
DEV_USER ?=
TYPE ?= continue
TYPE ?= opencode

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid TYPE silently defaults to OpenCode.

Add a guard before the helm upgrade call:
@if [ "$(TYPE)" != "opencode" ] && [ "$(TYPE)" != "continue" ]; then echo "ERROR: TYPE must be opencode or continue"; exit 1; fi

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed: TYPE must be opencode or continue; anything else errors.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Continue/Roo tests skip on OpenCode workspaces but no OpenCode assertion exists. With OpenCode now the default, a freshly deployed cluster runs the entire devspace smoke suite and reports every test as SKIPPED — zero actual assertions pass. The suite gives false confidence on new installs.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point. Soft-skipping Continue/Roo ConfigMaps stays intentional (they aren’t created for OpenCode). Added always-on OpenCode checks that work with started: false: test_opencode_devworkspace_exists and test_opencode_web_password_secret.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gateway API-key tests skip on OpenCode workspaces with no replacement coverage. pca-ai-gw-apikey Secret is created for all workspace types, but no test asserts it exists or is non-empty on OpenCode workspaces. The gateway wiring goes fully untested for the new default path.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on the wiring gap. Continue/Roo ConfigMap key checks still soft-skip on OpenCode. OpenCode RHCL/key wiring + chat now run on any-phase DevWorkspace CRs (not only Running), so fresh started: false installs are covered.

@itay1551
itay1551 merged commit 33f6082 into main Jul 29, 2026
1 check passed
@itay1551
itay1551 deleted the feat/opencode-default-ide branch July 29, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants