docs: sync READMEs with unified charts structure - #17
Merged
Conversation
PCA_Deployment_ROSA/README.md and PCA_Deployment_ARO/README.md still referenced the old argocd/ subdirectory structure that was removed when all Helm charts were unified under charts/ (feat/unify-charts). Update both deployment guides and the top-level README to reflect the current repo layout, chart names, and namespace. - Replace argocd/ directory trees with charts/ in both READMEs - Remove Step 3 instruction to manually edit argocd/00-app-of-apps.yaml (repo URL is now a Terraform variable, no file editing required) - Fix gitops_repo_path: "PCA_deployment/argocd" → "charts/pca-app-of-apps" in ROSA README and terraform.tfvars.example - Update Step 9 manual bootstrap to use helm template instead of oc apply - Add Wave 5 (pca-benchmarks) to ROSA deployment guide - Align Day-2 operation paths to charts/pca-ai-serving/values-rosa.yaml and charts/pca-devspaces/values-rosa.yaml - Fix ARO tool-call-parser: hermes → qwen3_xml (+ reasoning-parser=qwen3) in ServingRuntime args and troubleshooting section - Replace llm-d-multi-gpu with ai-serving in operational command examples
itay1551
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync deployment READMEs with the unified
charts/structure introduced in thefeat/unify-chartsmerge. The oldargocd/subdirectories insidePCA_Deployment_ROSA/andPCA_Deployment_ARO/were removed when all Helm charts were consolidated undercharts/at the repo root, but the deployment guides were not fully updated, leaving users stuck at instructions that reference files that no longer exist.Related Issues / Tickets
Closes #16
Type of Change
Changes
PCA_Deployment_ROSA/README.md— major update:argocd/directory tree with the actualcharts/layoutargocd/00-app-of-apps.yaml(the repo URL is now a Terraform variable — no file editing or commit required)gitops_repo_pathin the Step 4terraform.tfvarsexample:"PCA_deployment/argocd"→"charts/pca-app-of-apps"rosa-llm-driven-deployment.git→private-coding-assistant.gitoc apply -f ../argocd/00-app-of-apps.yaml→helm templatecommand with required valuespca-benchmarks) to the sync-wave monitoring tableargocd/03-ai-serving/…→charts/pca-ai-serving/values-rosa.yaml, etc.PCA_Deployment_ROSA/terraform/terraform.tfvars.example— fixgitops_repo_pathto"charts/pca-app-of-apps"PCA_Deployment_ARO/README.md:PCA_Deployment_ARO/argocd/tree, add unifiedcharts/layout with ARO-specificvalues-aro.yamloverlays noted--tool-call-parser=hermes→--tool-call-parser=qwen3_xml(+--reasoning-parser=qwen3) in the ServingRuntime args table, combined args block, and troubleshooting patch command — aligns with the parser compatibility table already present in the same fileREADME.md— replacellm-d-multi-gpuwithai-servingin operational command examples (patch commands, Roo Code JSON config, rollout procedures, metrics curl); leave historical test-record sections unchangedQuality Gates
yamllint,yamlfmt, secret scan)helm template) — not applicable, docs-only changeVerification
Steps to verify:
PCA_Deployment_ROSA/README.mdsteps 1–12 end-to-end and confirm no step references a non-existent path — requires a live ROSA cluster, not verifiedgrep -r "argocd/" PCA_Deployment_ROSA/ PCA_Deployment_ARO/returns no matches inside.mdfilesgrep "PCA_deployment/argocd" PCA_Deployment_ROSA/terraform/terraform.tfvars.examplereturns no matches