fix: set model id for custom models in llamastack config - #223
Merged
sauagarwa merged 1 commit intoJul 16, 2026
Conversation
The llama-stack subchart requires each enabled model to have an `id` field for `registered_resources.models.model_id`. When using a custom model not predefined in the subchart, this field was never set, causing a pydantic ValidationError on startup. Default the id to the model key name, with an optional LLM_ID/SAFETY_ID override. Made-with: Cursor
2 tasks
Collaborator
Author
|
Testing Tested on OpenShift cluster with custom remote model: Verification:
Result: The PR correctly allows LLM_ID to override the model identifier while LLM remains the YAML-safe config key. SAFETY model support also confirmed working. |
sauagarwa
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The llama-stack subchart requires each enabled model to have an
idfield forregistered_resources.models.model_id. When using a custom model not predefined in the subchart, this field was never set, causing a pydantic ValidationError on startup. Default the id to the model key name, with an optional LLM_ID/SAFETY_ID override.